blue/squawk
blue
/
squawk
2
3
Fork 6
Code Issues 21 Pull Requests 2 Actions Releases 10 Wiki Activity

feat/tray_pictogram #70

Open
pavanvo wants to merge 30 commits from pavanvo/squawk:feat/tray_pictogram into settings
pull from: pavanvo/squawk:feat/tray_pictogram
merge into: blue:settings
Conversation 2 Commits 30 Files Changed 82 +6134 -1609
pavanvo commented 2022-05-31 19:51:02 +00:00
First-time contributor
Copy Link

Hiding to tray and saving a prefence forks fine.

I'm testing only on Gnome 3.3(

If you check 'Hide Squawk to tray' you will see a squawk in tray, but uncheck - is not hiding icon

quawk::trayIcon->hide();and
Squawk::trayIcon->setVisible(false); it's not working

so I hope it will work fine on KDE

Hiding to tray and saving a prefence forks fine. I'm testing only on Gnome 3.3( If you check 'Hide Squawk to tray' you will see a squawk in tray, but uncheck - is not hiding icon `quawk::trayIcon->hide();`and `Squawk::trayIcon->setVisible(false);` it's not working so I hope it will work fine on KDE
pavanvo added 30 commits 2022-05-31 19:51:02 +00:00
blue commented 2022-06-02 06:47:52 +00:00
Owner
Copy Link

Hello again! Thank you so much for this pull request!
I'm not sure I agree with this way, my plan was to destroy Squawk window to leave only models in the memory when the app is folded to tray. I have rewritten main window recently specifically for that: to isolate models from views. I hope that way would save a lot of RAM.
What would you say, do you think we can do it that way? Can we have tray icon object in Application and can we destroy Squawk window on close?

Hello again! Thank you so much for this pull request! I'm not sure I agree with this way, my plan was to destroy Squawk window to leave only models in the memory when the app is folded to tray. I have rewritten main window recently specifically for that: to isolate models from views. I hope that way would save a lot of RAM. What would you say, do you think we can do it that way? Can we have tray icon object in Application and can we destroy Squawk window on close?
pavanvo commented 2022-06-02 09:32:27 +00:00
Author
First-time contributor
Copy Link

Yo, iterested idea!
Today I started to guess what we need to put icon to singleton (cuz we can have only one icon), to get access from every where.

So this will be compatible.

Yo, iterested idea! Today I started to guess what we need to put icon to singleton (cuz we can have only one icon), to get access from every where. So this will be compatible.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b pavanvo-feat/tray_pictogram settings
git pull feat/tray_pictogram

Step 2:

Merge the changes and update on Gitea.
git checkout settings
git merge --no-ff pavanvo-feat/tray_pictogram
git push origin settings
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something is not working

  
Documentation

Documentation related issues

  
Easy

   
Feature

New feature

  
Localization

Localization related issues

  
Packaging

Issues related to packaging and building

  
Refactoring

Need to reimplement something in a better way

  
Test

Need to test something

No Label
Bug
Documentation
Easy
Feature
Localization
Packaging
Refactoring
Test
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blue/squawk#70
No description provided.
Delete Branch "pavanvo/squawk:feat/tray_pictogram"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?