blue/squawk

Fork 8

feat/tray_pictogram #70

Open

pavanvo wants to merge 30 commits from pavanvo/squawk:feat/tray_pictogram into settings

pavanvo commented

2022-05-31 19:51:02 +00:00

First-time contributor

Hiding to tray and saving a prefence forks fine.

I'm testing only on Gnome 3.3(

If you check 'Hide Squawk to tray' you will see a squawk in tray, but uncheck - is not hiding icon

quawk::trayIcon->hide();and
Squawk::trayIcon->setVisible(false); it's not working

so I hope it will work fine on KDE

Hiding to tray and saving a prefence forks fine. I'm testing only on Gnome 3.3( If you check 'Hide Squawk to tray' you will see a squawk in tray, but uncheck - is not hiding icon `quawk::trayIcon->hide();`and `Squawk::trayIcon->setVisible(false);` it's not working so I hope it will work fine on KDE

pavanvo added 30 commits 2022-05-31 19:51:02 +00:00

0.2.1 4786388822

new screenshot 4baa3bccbf

first attempt to make About window 27377e0ec5

new tab in About: components 9f746d203b

License is now can be viewed locally, some organization name packaging issies 1b66fda318

Report bugs tab and thanks to tab in about widget 82d54ba4df

account refactoring, pep support discovery started 69e0c88d8d

ui squawk refactoring 2c26c7e264

account connect/disconnect now activate/deactivate, it's a bit less contraversial; async account password asking new concept f64e5c2df0

account removal bugfix, some testing ce686e121b

actual pasword reasking on failed authentication 8f949277f6

first attempt 51ac1ac709

a crash fix on one of archive corner cases 4c20a314f0

first ideas for notifications 18859cb960

better notification sending, edited message now modifies notification (or sends), little structure change 83cb220175

refactoring: UI squawk now belongs to a new class, it enables me doing trayed mode, when main window is destroyed 721d3a1a89

unread messages count now is displayed on the launcher icon 3916aec358

Now notifications have actions! Some more usefull functions to roster model e58213b294

some polish 2fcc432aef

an attempt to display text in a better way with QTextDocument + QTextBrowser d86e2c28a0

seem to have found a text block, to activate with the click later eac87e713f

link clicking and hovering in message body now works! 7ba94e9deb

merge conflicts, text copying from context menu in message line c3a45ec58c

first successfull attempt to visualize selection on message body 0340db7f2f

selection message body now actually working 3c48577eee

double click word selection handle, sigint sermentation fault fix 1f065f23e6

added en lolcalization file, actualized localizations 80c5e2f2b4

release 0.2.2 preparation 645b92ba51

feat: hide to tray on closing 93e6af3e20

style: remove useless code 21c0fe728d

blue commented

2022-06-02 06:47:52 +00:00

Owner

Hello again! Thank you so much for this pull request!
I'm not sure I agree with this way, my plan was to destroy Squawk window to leave only models in the memory when the app is folded to tray. I have rewritten main window recently specifically for that: to isolate models from views. I hope that way would save a lot of RAM.
What would you say, do you think we can do it that way? Can we have tray icon object in Application and can we destroy Squawk window on close?

Hello again! Thank you so much for this pull request! I'm not sure I agree with this way, my plan was to destroy Squawk window to leave only models in the memory when the app is folded to tray. I have rewritten main window recently specifically for that: to isolate models from views. I hope that way would save a lot of RAM. What would you say, do you think we can do it that way? Can we have tray icon object in Application and can we destroy Squawk window on close?

pavanvo commented

2022-06-02 09:32:27 +00:00

Author

First-time contributor

Yo, iterested idea!
Today I started to guess what we need to put icon to singleton (cuz we can have only one icon), to get access from every where.

So this will be compatible.

Yo, iterested idea! Today I started to guess what we need to put icon to singleton (cuz we can have only one icon), to get access from every where. So this will be compatible.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u feat/tray_pictogram:pavanvo-feat/tray_pictogram

git checkout pavanvo-feat/tray_pictogram

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout settings

git merge --no-ff pavanvo-feat/tray_pictogram

git checkout pavanvo-feat/tray_pictogram

git rebase settings

git checkout settings

git merge --ff-only pavanvo-feat/tray_pictogram

git checkout pavanvo-feat/tray_pictogram

git rebase settings

git checkout settings

git merge --no-ff pavanvo-feat/tray_pictogram

git checkout settings

git merge --squash pavanvo-feat/tray_pictogram