blue/squawk
blue
/
squawk
2
3
Fork 6
Code Issues 21 Pull Requests 2 Actions Releases 10 Wiki Activity

don't save settings on quit, if readSettings() not finished #56

Merged
blue merged 1 commits from shunf4/squawk:fix/wait_init_before_exit into messageFeed 2021-10-16 15:39:42 +00:00
Conversation 0 Commits 1 Files Changed 2 +38 -32
shunf4 commented 2021-10-06 16:46:32 +00:00
Contributor
Copy Link

Don't save settings on quit, if readSettings() not finished.

This is to prevent settings from being cleared.

This PR is based on #50. The changes for this PR is at the lastest commit.

Don't save settings on quit, if `readSettings()` not finished. This is to prevent settings from being cleared. This PR is based on #50. The changes for this PR is at the lastest commit.
shunf4 added 17 commits 2021-10-06 16:46:32 +00:00
blue merged commit 43bfaf9b7e into messageFeed 2021-10-16 15:39:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something is not working

  
Documentation

Documentation related issues

  
Easy

   
Feature

New feature

  
Localization

Localization related issues

  
Packaging

Issues related to packaging and building

  
Refactoring

Need to reimplement something in a better way

  
Test

Need to test something

No Label
Bug
Documentation
Easy
Feature
Localization
Packaging
Refactoring
Test
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blue/squawk#56
No description provided.
Delete Branch "shunf4/squawk:fix/wait_init_before_exit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?