WIP: fix: intialization ui/squawk.cpp before than Core::Squawk::ready #69

pavanvo · 2022-05-28T05:27:29Z

pavanvo commented

2022-05-28 05:27:29 +00:00

First-time contributor

When we load app with one acc, button add contact is not enabled.
It's happend cuz ui/squawk.cpp is initializing after the Core::Squawk::ready.

We can easily checkout this with the two breakpoints,
first on ui/models/account.cpp line 99
second on ui/squawk.cpp line 66

Event happent before subscribing

So this PR to fix this

When we load app with one acc, button add contact is not enabled. It's happend cuz ui/squawk.cpp is initializing after the `Core::Squawk::ready`. We can easily checkout this with the two breakpoints, first on `ui/models/account.cpp` line 99 second on `ui/squawk.cpp` line 66 Event happent before subscribing So this PR to fix this

pavanvo added 1 commit 2022-05-28 05:27:30 +00:00

11da9c8ae5 fix: intialization ui/squawk.cpp before than Core::Squawk::ready

blue commented

2022-05-30 11:16:23 +00:00

Hey! Thank you so much for participating!
I'm afraid this fix won't do, I'm planing to make Squawk main window closable to make it stay in the tray, so... there shall be additional state control in Application

Hey! Thank you so much for participating! I'm afraid this fix won't do, I'm planing to make Squawk main window closable to make it stay in the tray, so... there shall be additional state control in Application

pavanvo commented

2022-05-31 12:41:45 +00:00

First-time contributor

Yo, I started to write tray icon, there is no problems with it!
Pls wait a lil until i finished

Yo, I started to write tray icon, there is no problems with it! Pls wait a lil until i finished

blue commented

2022-06-03 06:48:38 +00:00

I think I have fixed it in a bit better way with my most recent commit

👍 1

pavanvo closed this pull request

2022-08-30 07:27:47 +00:00