blue/squawk
blue/squawk
2
3
Fork 8
Code Issues 23 Pull Requests 3 Actions Releases 10 Wiki Activity

set QSettings account array size when saving #61

Closed
shunf4 wants to merge 1 commits from fix/acc_setting_unsaved into messageFeed
pull from: fix/acc_setting_unsaved
merge into: blue:messageFeed
Conversation 0 Commits 1 Files Changed 1 +1 -1
shunf4 commented 2021-12-19 14:32:16 +00:00
Contributor
Copy Link

if the app is killed (like, by Windows when shutting down) between beginWriteArray endArray, things can go bad: setting core/accounts/size is not written, then next time squawk launches, the account array becomes empty.

So it's better we set the size of core/accounts array as early as beginWriteArray.

if the app is killed (like, by Windows when shutting down) between `beginWriteArray` `endArray`, things can go bad: setting `core/accounts/size` is not written, then next time squawk launches, the account array becomes empty. So it's better we set the size of `core/accounts` array as early as `beginWriteArray`.
shunf4 added 1 commit 2021-12-19 14:32:16 +00:00
blue closed this pull request 2022-01-09 14:41:47 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Something is not working
Documentation
Documentation related issues
Easy
Feature
New feature
Localization
Localization related issues
Packaging
Issues related to packaging and building
Refactoring
Need to reimplement something in a better way
Test
Need to test something
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blue/squawk#61
No description provided.
Delete Branch "fix/acc_setting_unsaved"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?