blue
/
squawk
1
1
Fork 4
Code Issues 14 Pull Requests 3 Releases 9 Wiki Activity
Labels Milestones

set QSettings account array size when saving #61

Closed
shunf4 wants to merge 1 commits from fix/acc_setting_unsaved into messageFeed
Conversation 0 Commits 1 Files Changed 1
shunf4 commented 7 months ago

if the app is killed (like, by Windows when shutting down) between beginWriteArray endArray, things can go bad: setting core/accounts/size is not written, then next time squawk launches, the account array becomes empty.

So it's better we set the size of core/accounts array as early as beginWriteArray.

if the app is killed (like, by Windows when shutting down) between `beginWriteArray` `endArray`, things can go bad: setting `core/accounts/size` is not written, then next time squawk launches, the account array becomes empty. So it's better we set the size of `core/accounts` array as early as `beginWriteArray`.
shunf4 added 1 commit 7 months ago
blue closed this pull request 6 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
Bug
Something is not working Documentation
Documentation related issues Feature
New feature Localization
Localization related issues Packaging
Issues related to packaging and building Refactoring
Need to reimplement something in a better way Test
Need to test something
No Label Bug Documentation Feature Localization Packaging Refactoring Test
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/acc_setting_unsaved'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes