blue
/
squawk
1
1
Fork 3
Code Issues 13 Pull Requests Releases 6 Wiki Activity
Labels Milestones
New Pull Request

Refactor CMakeLists #46

Merged
blue merged 5 commits from vae/squawk:build-refactor into messageFeed 6 months ago
Conversation 1 Commits 5 Files Changed 29
vae commented 6 months ago
There is no content yet.
vae added 4 commits 6 months ago
vae commented 6 months ago
Poster

Also, this closes #45.

Also, this closes #45.
blue reviewed 6 months ago
blue left a comment

Там есть 2 места, они наркоманские, я не уверен что сделал правильно, но так они сломаются

core/passwordStorageEngines/CMakeLists.txt
wrappers/kwallet.cpp
if (WITH_KWALLET)
target_sources(squawk PRIVATE
wrappers/kwallet.cpp
blue commented 6 months ago
Poster
Owner

А вот так вот точно нельзя, это должно быть миниатюрной разделяемой библиотекой, я её в рантайме пробую загрузить как плагин

А вот так вот точно нельзя, это должно быть миниатюрной разделяемой библиотекой, я её в рантайме пробую загрузить как плагин
blue marked this conversation as resolved
plugins/CMakeLists.txt Outdated
install(TARGETS openFileManagerWindowJob DESTINATION ${CMAKE_INSTALL_LIBDIR})
endif()
if (WITH_KIO)
target_sources(squawk PRIVATE openfilemanagerwindowjob.cpp)
blue commented 6 months ago
Poster
Owner

Тут тоже нельзя, вот эту штуку надо сделать разделяемой либой

Тут тоже нельзя, вот эту штуку надо сделать разделяемой либой
vae commented 6 months ago
Poster

ок, поправлю сейчас тогда

ок, поправлю сейчас тогда
blue marked this conversation as resolved
vae added 1 commit 6 months ago
blue merged commit bd07c49755 into messageFeed 6 months ago
The pull request has been merged as bd07c49755.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
Bug
Something is not working Documentation
Documentation related issues Feature
New feature Localization
Localization related issues Packaging
Issues related to packaging and building Refactoring
Need to reimplement something in a better way Test
Need to test something
No Label Bug Documentation Feature Localization Packaging Refactoring Test
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'vae/squawk:build-refactor'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes