some more tests, one subtle but important bugfix with cache

test/storagecursor.cpp

@@ -34,6 +34,7 @@ protected:
     static LMDBAL::Base* db;
     static LMDBAL::Cursor<uint64_t, std::string>* cursor;
     static LMDBAL::Cursor<uint64_t, std::string>* emptyCursor;
+    static LMDBAL::TransactionID transaction;
 
     LMDBAL::Storage<uint64_t, std::string>* table;
     LMDBAL::Storage<uint64_t, std::string>* emptyTable;
@@ -42,6 +43,7 @@ protected:
 LMDBAL::Base* StorageCursorTest::db = nullptr;
 LMDBAL::Cursor<uint64_t, std::string>* StorageCursorTest::cursor = nullptr;
 LMDBAL::Cursor<uint64_t, std::string>* StorageCursorTest::emptyCursor = nullptr;
+LMDBAL::TransactionID StorageCursorTest::transaction = nullptr;
 
 static const std::map<uint64_t, std::string> data({
     {245665783, "bothering nerds"},
@@ -167,9 +169,106 @@ TEST_F(StorageCursorTest, Destruction) {
     EXPECT_THROW(cursor->next(), LMDBAL::CursorNotReady);
     EXPECT_THROW(cursor->prev(), LMDBAL::CursorNotReady);
     EXPECT_THROW(cursor->current(), LMDBAL::CursorNotReady);
+
+    EXPECT_THROW(emptyTable->destroyCursor(cursor), LMDBAL::Unknown);
+    table->destroyCursor(cursor);
+
+    cursor = table->createCursor();
+}
+
+TEST_F(StorageCursorTest, FirstPublic) {
+    transaction = db->beginReadOnlyTransaction();
+
+    cursor->open(transaction);
+    std::pair<uint64_t, std::string> element = cursor->first();
+    std::map<uint64_t, std::string>::const_iterator reference = data.begin();
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+}
+
+TEST_F(StorageCursorTest, NextPublic) {
+    std::map<uint64_t, std::string>::const_iterator reference = data.begin();
+
+    reference++;
+    for (; reference != data.end(); ++reference) {
+        std::pair<uint64_t, std::string> element = cursor->next();
+        EXPECT_EQ(element.first, reference->first);
+        EXPECT_EQ(element.second, reference->second);
+    }
+
+    EXPECT_THROW(cursor->next(), LMDBAL::NotFound);
+
+    std::pair<uint64_t, std::string> element = cursor->first();
+    reference = data.begin();
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+}
+
+TEST_F(StorageCursorTest, LastPublic) {
+    std::pair<uint64_t, std::string> element = cursor->last();
+    std::map<uint64_t, std::string>::const_reverse_iterator reference = data.rbegin();
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+}
+
+TEST_F(StorageCursorTest, PrevPublic) {
+    std::map<uint64_t, std::string>::const_reverse_iterator reference = data.rbegin();
+
+    reference++;
+    for (; reference != data.rend(); ++reference) {
+        std::pair<uint64_t, std::string> element = cursor->prev();
+        EXPECT_EQ(element.first, reference->first);
+        EXPECT_EQ(element.second, reference->second);
+    }
+
+    EXPECT_THROW(cursor->prev(), LMDBAL::NotFound);
+
+    std::pair<uint64_t, std::string> element = cursor->last();
+    reference = data.rbegin();
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+}
+
+TEST_F(StorageCursorTest, CurrentPublic) {
+    std::pair<uint64_t, std::string> element = cursor->first();
+    std::map<uint64_t, std::string>::const_iterator reference = data.begin();
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+
+    element = cursor->current();
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+
+    cursor->next();
+    element = cursor->current();
+    ++reference;
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
+
+    cursor->next();
+    cursor->next();
+    cursor->prev();
+    element = cursor->current();
+    ++reference;
+    ++reference;
+    --reference;
+
+    EXPECT_EQ(element.first, reference->first);
+    EXPECT_EQ(element.second, reference->second);
 }
 
 TEST_F(StorageCursorTest, CornerCases) {
+    db->abortTransaction(transaction);
+    EXPECT_THROW(cursor->current(), LMDBAL::Unknown);
+    cursor->close();
+
     emptyCursor->open();
     EXPECT_THROW(emptyCursor->first(), LMDBAL::NotFound);
     EXPECT_THROW(emptyCursor->last(), LMDBAL::NotFound);