Always re-send Matrix reactions and harden component-mode avatars #6

Merged
skunky merged 1 commit from outgoing-reactions into main 2026-11-08 22:12:02 +00:00
Owner
  • Reactions Matrix → XMPP: the framework suppressed a reaction as a duplicate when a stale reaction row existed (left behind by failed sends or failed removals), so no stanza was ever sent. PreHandleMatrixReaction now removes a stale same-emoji row; HandleMatrixReactionRemove deletes the row before attempting the send. XEP-0444 reactions are idempotent full sets, so re-sending is always safe.
  • Avatars: puppet vCard lookups work without the in-memory join index after restarts (findPuppetMXIDByLocalpart scans persisted portal puppet lists); puppet join presence carries the XEP-0153 photo hash when the profile is already cached.
  • Docs: AGENTS.md and README explain that MUC avatars require a non-anonymous room in both directions.
- **Reactions Matrix → XMPP**: the framework suppressed a reaction as a duplicate when a stale reaction row existed (left behind by failed sends or failed removals), so no stanza was ever sent. `PreHandleMatrixReaction` now removes a stale same-emoji row; `HandleMatrixReactionRemove` deletes the row before attempting the send. XEP-0444 reactions are idempotent full sets, so re-sending is always safe. - **Avatars**: puppet vCard lookups work without the in-memory join index after restarts (`findPuppetMXIDByLocalpart` scans persisted portal puppet lists); puppet join presence carries the XEP-0153 photo hash when the profile is already cached. - **Docs**: AGENTS.md and README explain that MUC avatars require a non-anonymous room in both directions.
Always re-send Matrix reactions and harden component-mode avatars
Some checks failed
CI / test (pull_request) Has been cancelled
58cb84f026
Reactions Matrix -> XMPP: the framework silently suppresses a reaction when
a stored reaction row with the same (message, sender, emoji) already exists.
Rows left behind by failed sends/removals made every re-add a no-op with no
stanza ever sent. PreHandleMatrixReaction now removes a stale same-emoji row
and HandleMatrixReactionRemove deletes the row before attempting the send;
XEP-0444 reactions are idempotent full sets, so re-sending is always safe.

Avatars: puppet vCard lookups no longer depend on the in-memory join index
(findPuppetMXIDByLocalpart scans persisted portal puppet lists after
restarts), and puppet join presence carries the XEP-0153 photo hash when the
profile is cached. Document that MUC avatars require a non-anonymous room.
skunky merged commit 562cd128ff into main 2026-11-08 22:12:02 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
xmpp-bridge/mautrix-xmpp!6
No description provided.