don't save settings on quit, if readSettings() not finished

core/squawk.cpp

@@ -27,7 +27,8 @@ Core::Squawk::Squawk(QObject* parent):
     accounts(),
     amap(),
     network(),
-    waitingForAccounts(0)
+    waitingForAccounts(0),
+    isInitialized(false)
 #ifdef WITH_KWALLET
     ,kwallet()
 #endif
@@ -66,39 +67,42 @@ void Core::Squawk::stop()
 {
     qDebug("Stopping squawk core..");
     network.stop();
-    QSettings settings;
-    settings.beginGroup("core");
-    settings.beginWriteArray("accounts");
-    SimpleCrypt crypto(passwordHash);
-    for (std::deque<Account*>::size_type i = 0; i < accounts.size(); ++i) {
-        settings.setArrayIndex(i);
-        Account* acc = accounts[i];
 
-        Shared::AccountPassword ap = acc->getPasswordType();
+    if (isInitialized) {
-        QString password;
+        QSettings settings;
+        settings.beginGroup("core");
+        settings.beginWriteArray("accounts");
+        SimpleCrypt crypto(passwordHash);
+        for (std::deque<Account*>::size_type i = 0; i < accounts.size(); ++i) {
+            settings.setArrayIndex(i);
+            Account* acc = accounts[i];
 
-        switch (ap) {
+            Shared::AccountPassword ap = acc->getPasswordType();
-            case Shared::AccountPassword::plain:
+            QString password;
-                password = acc->getPassword();
+
-                break;
+            switch (ap) {
-            case Shared::AccountPassword::jammed:
+                case Shared::AccountPassword::plain:
-                password = crypto.encryptToString(acc->getPassword());
+                    password = acc->getPassword();
-                break;
+                    break;
-            default:
+                case Shared::AccountPassword::jammed:
-                break;
+                    password = crypto.encryptToString(acc->getPassword());
+                    break;
+                default:
+                    break;
+            }
+
+            settings.setValue("name", acc->getName());
+            settings.setValue("server", acc->getServer());
+            settings.setValue("login", acc->getLogin());
+            settings.setValue("password", password);
+            settings.setValue("resource", acc->getResource());
+            settings.setValue("passwordType", static_cast<int>(ap));
         }
+        settings.endArray();
+        settings.endGroup();
 
-        settings.setValue("name", acc->getName());
+        settings.sync();
-        settings.setValue("server", acc->getServer());
-        settings.setValue("login", acc->getLogin());
-        settings.setValue("password", password);
-        settings.setValue("resource", acc->getResource());
-        settings.setValue("passwordType", static_cast<int>(ap));
     }
-    settings.endArray();
-    settings.endGroup();
-    
-    settings.sync();
     
     emit quit();
 }
@@ -108,6 +112,7 @@ void Core::Squawk::start()
     qDebug("Starting squawk core..");
     
     readSettings();
+    isInitialized = true;
     network.start();
 }
 

core/squawk.h

@@ -133,6 +133,7 @@ private:
     Shared::Availability state;
     NetworkAccess network;
     uint8_t waitingForAccounts;
+    bool isInitialized;
 
 #ifdef WITH_KWALLET
     PSE::KWallet kwallet;