From 4c20a314f050236fbcb79fa2d43322ec9045eaa1 Mon Sep 17 00:00:00 2001
From: blue <blue@macaw.me>
Date: Sun, 17 Apr 2022 16:25:15 +0300
Subject: [PATCH] a crash fix on one of archive corner cases

---
 CHANGELOG.md        |  1 +
 core/rosteritem.cpp | 28 ++++++++++++++++++----------
 2 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 55ef1f1..4daf652 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
 ### Bug fixes
 - now when you remove an account it actually gets removed
 - segfault on unitialized Availability in some rare occesions
+- fixed crash when you open a dialog with someone that has only error messages in archive
 
 ### Improvements
 - there is a way to disable an account and it wouldn't connect when you change availability
diff --git a/core/rosteritem.cpp b/core/rosteritem.cpp
index b1951d6..1b8d1e6 100644
--- a/core/rosteritem.cpp
+++ b/core/rosteritem.cpp
@@ -124,15 +124,19 @@ void Core::RosterItem::nextRequest()
         if (requestedCount != -1) {
             bool last = false;
             if (archiveState == beginning || archiveState == complete) {
-                QString firstId = archive->oldestId();
-                if (responseCache.size() == 0) {
-                    if (requestedBefore == firstId) {
-                        last = true;
-                    }
-                } else {
-                    if (responseCache.front().getId() == firstId) {
-                        last = true;
+                try {
+                    QString firstId = archive->oldestId();
+                    if (responseCache.size() == 0) {
+                        if (requestedBefore == firstId) {
+                            last = true;
+                        }
+                    } else {
+                        if (responseCache.front().getId() == firstId) {
+                            last = true;
+                        }
                     }
+                } catch (const Archive::Empty& e) {
+                    last = true;
                 }
             } else if (archiveState == empty && responseCache.size() == 0) {
                 last = true;
@@ -171,8 +175,12 @@ void Core::RosterItem::performRequest(int count, const QString& before)
                 requestCache.emplace_back(requestedCount, before);
                 requestedCount = -1;
             }
-            Shared::Message msg = archive->newest();
-            emit needHistory("", getId(msg), msg.getTime());
+            try {
+                Shared::Message msg = archive->newest();
+                emit needHistory("", getId(msg), msg.getTime());
+            } catch (const Archive::Empty& e) {                     //this can happen when the only message in archive is not server stored (error, for example)
+                emit needHistory(before, "");
+            }
         }
             break;
         case end: