Some thoughts about poll

handler/login.cpp

@@ -34,7 +34,7 @@ void Handler::Login::handle(Request& request) {
         success = server->validatePassword(login, password);
     } catch (const DBInterface::NoLogin& e) {
         std::cerr << "Exception on logging in:\n\t" << e.what() << std::endl;
-        return error(request, Result::noLogin, Response::Status::badRequest); //can send unauthed instead, to exclude login spoofing
+        return error(request, Result::wrongCredentials, Response::Status::badRequest);
     } catch (const std::exception& e) {
         std::cerr << "Exception on logging in:\n\t" << e.what() << std::endl;
         return error(request, Result::unknownError, Response::Status::internalError);
@@ -43,7 +43,7 @@ void Handler::Login::handle(Request& request) {
         return error(request, Result::unknownError, Response::Status::internalError);
     }
     if (!success)
-        return error(request, Result::noLogin, Response::Status::badRequest);
+        return error(request, Result::wrongCredentials, Response::Status::badRequest);
 
     nlohmann::json body = nlohmann::json::object();
     body["result"] = Result::success;

handler/login.h

@@ -19,6 +19,7 @@ public:
         emptyLogin,
         noPassword,
         emptyPassword,
+        wrongCredentials,
         unknownError
     };
 

handler/poll.cpp

@@ -0,0 +1,44 @@
+//  SPDX-FileCopyrightText: 2023 Yury Gubich <blue@macaw.me>
+//  SPDX-License-Identifier: GPL-3.0-or-later
+
+#include "handler/poll.h"
+
+#include "response/response.h"
+#include "server/server.h"
+#include "request/redirect.h"
+
+Handler::Poll::Poll (Server* server):
+    Handler("login", Request::Method::get),
+    server(server)
+{}
+
+void Handler::Poll::handle (Request& request) {
+    std::string access = request.getAuthorizationToken();
+    if (access.empty())
+        return error(request, Result::tokenProblem, Response::Status::unauthorized);
+    
+    if (access.size() != 32) 
+        return error(request, Result::tokenProblem, Response::Status::badRequest);
+      
+    try {
+        Session& session = server->getSession(access);
+        throw Redirect(&session);
+    } catch (const Redirect& r) {
+        throw r;
+    } catch (const std::exception& e) {
+        std::cerr << "Exception on poll:\n\t" << e.what() << std::endl;
+        return error(request, Result::unknownError, Response::Status::internalError);
+    }  catch (...) {
+        std::cerr << "Unknown exception on poll" << std::endl;
+        return error(request, Result::unknownError, Response::Status::internalError);
+    }
+}
+
+void Handler::Poll::error(Request& request, Result result, Response::Status status) const {
+    Response& res = request.createResponse(status);
+    nlohmann::json body = nlohmann::json::object();
+    body["result"] = result;
+    
+    res.setBody(body);
+    res.send();
+}

handler/poll.h

@@ -0,0 +1,32 @@
+//  SPDX-FileCopyrightText: 2023 Yury Gubich <blue@macaw.me>
+//  SPDX-License-Identifier: GPL-3.0-or-later
+
+#pragma once
+
+#include "handler.h"
+#include "request/request.h"
+#include "response/response.h"
+
+class Server;
+namespace Handler {
+
+class Poll : public Handler {
+public:
+    Poll(Server* server);
+    void handle(Request& request) override;
+    
+    enum class Result {
+        success,
+        tokenProblem,
+        replace,
+        timeout,
+        unknownError
+    };
+  
+    void error(Request& request, Result result, Response::Status status) const;
+private:
+    Server* server;
+  
+};
+
+}